Fix PCSG handling #104
Merged
Fix PCSG handling #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 56.45% 61.25% +4.79%
==========================================
Files 7 7
Lines 542 542
==========================================
+ Hits 306 332 +26
+ Misses 236 210 -26 ☔ View full report in Codecov by Sentry. |
ReubenJ
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Not sure on #102, because other methods currently display a warning and assume uniform probabilities.
If you want to add an extra Base.show method for probabilistic grammars, we can either define this in Core or define it over CSGs instead of AbstractGrammars.
|
Will discard prettier |
ReubenJ
requested changes
Feb 19, 2025
ReubenJ
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_probabilisticnormalize!not exported + not defined for non-probabilistic case #102add prettierBase.showfor probabilistic grammars.